Opened 7 years ago

Closed 7 years ago

#1072 closed enhancement/feature request (fixed)

[PATCH+ICONS] Some new POI icons

Reported by: erfabbri Owned by: KaZeR
Priority: major Milestone:
Component: core Version: git master
Severity: Keywords:
Cc:

Description

i made svg icons and a patch to include 4 new POIs (amenity=car_sharing, shop=bicycle, amenity=bicycle_rental, amenity=bicycle_parking) in the next mainstream.

icons licence is public domain

you can decide in wich layout and what zoom level sholud be added each poi, with the proper itemgra line in navit.xml

i made the icon for shop=bicycle cause is not in the xpm folder, but it was already implemented in osm.c and item_def.h

note:remember that amenity=bicycle_rental in OSM is used to tag the bikesharing docking stations. places for renting a bike are tagged as shop=bicycle plus service:bicycle:rental=yes

cheers

Attachments (3)

icons.tar.gz (5.4 KB) - added by erfabbri 7 years ago.
newpois.patch (1.0 KB) - added by erfabbri 7 years ago.
navit_shipped.xml.patch (10.7 KB) - added by erfabbri 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by erfabbri

Changed 7 years ago by erfabbri

comment:1 follow-up: Changed 7 years ago by tryagain

Hi!

If we are adding some new icons, we should refernce them from navit.xml, else nobody will see them.

At least, bike parkings (and, probably, bike shops/rentals) should be visible in bike layout. So please suggest your changes to navit_shipped.xml to use new item types an icons.

tryagain

Changed 7 years ago by erfabbri

comment:2 in reply to: ↑ 1 Changed 7 years ago by erfabbri

Replying to http://wiki.navit-project.org/index.php/user:tryagain:

Hi!

If we are adding some new icons, we should refernce them from navit.xml, else nobody will see them.

At least, bike parkings (and, probably, bike shops/rentals) should be visible in bike layout. So please suggest your changes to navit_shipped.xml to use new item types an icons.

tryagain

i attached a patch with my suggested changes to navit_shipped.xml. i included bicycle_parking and bicycle_rental (bikesharing docking stations) only in Bike layout. car_sharing and bicycle_shop are in Car layout (so in bike layout also). Please check if everything is fine, also with Android layout, i don't know about that. Thanks

comment:3 Changed 7 years ago by tryagain

  • Resolution set to fixed
  • Status changed from new to closed

Patches and icons are added in r5245

Note: See TracTickets for help on using tickets.