Opened 5 years ago

Closed 4 years ago

#1100 closed enhancement/feature request (fixed)

Visit before a destination in GTK

Reported by: me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a Owned by: turulomio
Priority: major Milestone: version 0.5.0
Component: gui/gtk Version: git master
Severity: Keywords:
Cc: sebastian.leske@…

Description

Hi. This is my first patch, I hope you like it I made a patch to let add a "visit before destination" from GTK. When you have a destination and make right click in other point you get a popup with "Visit before" option. You can select to which waypoint you want to go before

Attachments (1)

visit_before_in_gtk.diff (2.0 KB) - added by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a 5 years ago.
Visit before in gtk subversion patch

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a

Visit before in gtk subversion patch

comment:1 Changed 5 years ago by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a

  • Summary changed from Visit before a destinatio in GTK to Visit before a destination in GTK

comment:2 Changed 5 years ago by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a

I think this way it's a "little" slow

I just want to submit a patch and try to contribute this project with other patches soon

Perhaps my patch was terrible, please just tell me something

Thank you

Last edited 5 years ago by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a (previous) (diff)

comment:3 Changed 5 years ago by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a

  • Milestone changed from To be discussed - Give your opinion! to version 0.5.0
  • Priority changed from minor to major

comment:4 Changed 5 years ago by sleske

  • Cc sebastian.leske@… added

Welcome to Navit, and thank you for your patch!

I understand that it's frustrating having to wait so long for feedback. However, please understand that everyone here is a volunteer, with their own schedules.

I'll try to have a look at the patch. Might take a while, though.

comment:5 Changed 5 years ago by me.yahoo.com/a/_ij44v97roulszbeztrzcqzaaiyvlg--#9d14a

Thank you

comment:6 Changed 4 years ago by sleske

  • Resolution set to fixed
  • Status changed from new to closed

Patch committed in rev. 5444 . Thanks!

Note: The patch reuses the variable dstcount, which is a bit ugly. I changed that in the following commit.

Note: See TracTickets for help on using tickets.