Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1119 closed enhancement/feature request (fixed)

[PATCH] Move intl_cmake into support folder

Reported by: ftom.myopenid.com Owned by: KaZeR
Priority: minor Milestone: version 0.5.1
Component: core Version: git master
Severity: Keywords: intl_cmake, libintl, cmake, build
Cc: cp15, sebastian.leske@…

Description

The folder "navit/intl_cmake" contains parts of the gnu gettext implementation. In my opinion it should be better placed in the "navit/support" folder.

Steps to move the code:

  • Apply the attached patch
  • svn move navit/intl_cmake navit/support/gettext_intl

There is a folder "intl/" in the project root. Is this folder still needed? If not, cleanup:

  • svn remove intl

Attachments (1)

patch_svn5496_move_intl.diff (2.3 KB) - added by ftom.myopenid.com 5 years ago.
patch generated by svn diff, prepares move of intl_cmake

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by ftom.myopenid.com

patch generated by svn diff, prepares move of intl_cmake

comment:1 Changed 4 years ago by usul

  • Cc cp15 added
  • Keywords cmake build added
  • Milestone set to version 0.5.1

I support this request, to cleanup our source structure :) Any opinions on that or can anybody apply the patch?

comment:2 Changed 4 years ago by sleske

I'll try to take care of this.

The renaming makes sense. I'll test it, and probably commit it in the next few days unless there's a problem.

The folder intl/ is currently used by the autotools build. It's probably best to keep it until we remove the autotools build.

comment:3 Changed 4 years ago by sleske

  • Resolution set to fixed
  • Status changed from new to closed

Patch applied in r5619.

The folder intl will have to stay for now, so I'm closing this ticket.

comment:4 Changed 4 years ago by sleske

  • Cc sebastian.leske@… added
Note: See TracTickets for help on using tickets.