Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1272 closed defect/bug (fixed)

navit takes roundabout wrong way

Reported by: bafplus Owned by: cp15
Priority: major Milestone:
Component: navigation/highfive Version: git master
Severity: normal Keywords: roundabout direction
Cc: bafplus

Description

In this particular roundabout navit tels you to drive clockwise instead of counterclockwise. I thinks its an OSM error but can't find anything wrong in openstreetmaps.org

Link to roundabout in OSM: http://www.openstreetmap.org/way/7207585#map=17/51.57556/5.06633

Change History (9)

comment:1 Changed 5 years ago by bafplus

  • Resolution set to fixed
  • Status changed from new to closed

Jandegr found the error on OSM and corrected it, thanks!

comment:2 Changed 5 years ago by jandegr

  • Resolution fixed deleted
  • Status changed from closed to reopened

Despite me adding the oneway tag in OSM, fixing this case, this is in fact a bug since oneway is implied in OSM junction=roundabout, so the oneway tag is optional. Navit however does not seem to apply the implied oneway. http://wiki.openstreetmap.org/wiki/Tag:junction%3Droundabout So I reopen it untill fixed.

comment:3 Changed 5 years ago by tryagain

Hm...

We have code which makes each junction=roundabout into oneway by adding AF_ONEWAY flag, see lines 1027-1029 of current osm.c.

Are there any unfixed junctions left in OSM?

comment:4 Changed 5 years ago by jandegr

It suffers exactly the same as the Lucca sample (#1175), but the discription of this ticket, combined with the abscent oneway tag made me think it was bad routing, but in fact it's a failure of navigation.c to display a correct OSD icon for next turn. This roundabout also displays a clockwise roundabout icon. I removed the oneway tag in OSM and rebuilt a map, apparently maptool works fine and applies the mandatory AF_ONEWAY as it should.

comment:5 Changed 5 years ago by mvglasow (2)

A fix has been implemented as part of Project HighFive?, thus the issue should be solved once Project HighFive? gets merged into SVN.

comment:6 Changed 5 years ago by jandegr

tested with b3c1456 and indeed a huge improvement.

comment:7 Changed 5 years ago by jandegr

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 5 years ago by jandegr

The fix is included in the new navigation.c code, reachable on github awaiting it's commit. see #1082 for a link to it.

comment:9 Changed 5 years ago by jandegr

  • Component changed from mapdrivers/OSM to navigation/highfive
Note: See TracTickets for help on using tickets.