Opened 8 years ago

Closed 7 years ago

#1274 closed defect/bug (fixed)

navigation.c : annoying 'into the street'

Reported by: jandegr Owned by: robotaxi
Priority: major Milestone: version 0.5.1
Component: navigation/highfive Version: git master
Severity: normal Keywords:


Hi, All of the time instructions like 'in 100 meter trun left into the street someStreet' are heard. navigation.c handles this only for the german language. It is not desirable to hardcode this for every language in the world so the attached diff serves as an illustration of the issue and a 'fixes it for bafplus and me' untill someone turns up with a more elegant solution. Nevertheless suggestions for more entries in the table are welcome.

more detailed explanation: if the substring 'street' is found in streetname the the message will be shortened to 'in 100 meter turn left into someStreet' So for the english language the table shoud contain entries like street, road, alley, Also a gender can be specified for languages where that matters.

regards, Jan

Attachments (1)

0411.diff (6.6 KB) - added by jandegr 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by jandegr

comment:1 Changed 8 years ago by jandegr

  • Cc added

comment:2 Changed 8 years ago by jandegr

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 8 years ago by kazer

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 Changed 8 years ago by kazer

We should keep this ticket open until the patch is rejected, or merge into the trunk.

comment:5 Changed 8 years ago by kazer

You removed some magic numbers and fixed some comments not complying the coding guideline. Awesome, thanks :)

comment:6 Changed 8 years ago by jandegr

Hi, I was recently pointed to the fact that in some languages it can cause linguistic problems once it gets to the point where the scentences for the speech are composed. So I suggest the following approach and use two examples to illustrate : If it says 'go left into the street 52nd street' I think everybody agrees it is sensible to remove 'the street'. If there is doubt when it concerns a boulevard, then don't include boulevard in the list and leave that as it is. Result : many cases solved in a 100% correct manner, lots of cases not solved, final sum overall : an improvement of Navit and no cases are made worse, and I think that makes it worth doing. I don't think that the solution that was already provided for German, even has the potential to just solve everything in any language, but it certainly can solve many cases in a good way, it's a simple piece of code and it's already there, but only the German speaking can enjoy it up to now.

My only worries are that at some point one language will start acting-up on another one if the number of entries grow more and more.

It also helps to shorten spoken messages. While testing something else I now hear the following, it's in dutch this time but everyone will get it :

ga na 100 meter scherp naar rechts de straat J Arthur Younger Freeway CA92 in

By the time Navit is halfway that scentence I already think : 'beep beep Navit, please come to the point' and then I don't even care anymore if removing 'de straat' ('the street' in english) is linguistically correct or not.

Last edited 8 years ago by jandegr (previous) (diff)

comment:7 Changed 8 years ago by jandegr

  • Component changed from core to navigation/highfive

comment:8 Changed 7 years ago by robotaxi

  • Milestone set to version 0.5.1
  • Owner changed from KaZeR to robotaxi
  • Status changed from reopened to new
  • Summary changed from naviagtion.c : annoying 'into the street' to navigation.c : annoying 'into the street'

comment:9 Changed 7 years ago by robotaxi

  • Status changed from new to assigned

comment:10 Changed 7 years ago by mvglasow (2)

  • Resolution set to fixed
  • Status changed from assigned to closed

navigation.c has changed quite a lot since this patch, but I've merged what was still left to merge.

Also, the "into the street" part was fixed as part of Project HighFive?. I think we can close this one.

Note: See TracTickets for help on using tickets.