Opened 12 years ago

Closed 10 years ago

#201 closed defect/bug (fixed)

gpx logging: do not log 0000 0000 postions

Reported by: udo Owned by: KaZeR
Priority: major Milestone: version 0.2.0
Component: core Version: git master
Severity: Keywords:
Cc:

Description

For the gpx logging navit should ignore the 0000 0000 positions that GPSses might give when starting up.

Attachments (2)

gpxlog.patch (447 bytes) - added by RedDog 12 years ago.
gpxlog2-rfc.patch (1.3 KB) - added by RedDog 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by KaZeR

  • Milestone set to version 0.1.0
  • Owner changed from somebody to KaZeR
  • Status changed from new to assigned

comment:2 Changed 12 years ago by RedDog

vehicle_log_gpx() handles this: if (!this_->meth.position_attr_get(this_->priv, attr_position_coord_geo, &pos_attr))

Maybe something like this (patch attached) may help here. Patch is only an idea, not tested ... (maybe not the best to handle this)

Changed 12 years ago by RedDog

comment:3 Changed 12 years ago by KaZeR

Thanks for the patch, but better would be to check fix_type in the gpx log. There might be cases where position_coord_geo should better return the old values instead of nothing : for example if you want to re-center the map at your current position, and you have weak gps reception, nothing will happen. When position_coord_geo returns the old values, the map will at least re-center at you old coordinates

Changed 12 years ago by RedDog

comment:4 Changed 12 years ago by RedDog

I attached a new patch... It's not tested! Only for RFC..

comment:5 Changed 10 years ago by akashihi

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r3381

Thanks for your patch! I've modified it, so it checks, whether fix is valid only if fix_type retrieval was successfull

Note: See TracTickets for help on using tickets.