Opened 11 years ago

Closed 11 years ago

#376 closed defect/bug (fixed)

A few errors in version svn2304. I've created the fix as a patch for the current version svn2315

Reported by: Worldcitizen Owned by: KaZeR
Priority: blocker Milestone:
Component: core Version: git master
Severity: Keywords:
Cc:

Description

Buildservice found a few errors in svn2304:

I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: navit voidreturn graphics_gtk_drawing_area.c:682 E: navit 64bit-portability-issue map.c:534 E: navit 64bit-portability-issue street.c:1050, 1158, 1159, 1287, 1363

Attachments (4)

navit-snapshot-x86_64.2.patch (16 bytes) - added by Worldcitizen 11 years ago.
empty don't use
navit-snapshot-x86_64.patch (1.2 KB) - added by Worldcitizen 11 years ago.
navit-snapshot-fix.patch (1.2 KB) - added by Worldcitizen 11 years ago.
Patch name as i use also use in my navit-snapshot build. Is fully tested on version svn2315
navit-fix.patch (1000 bytes) - added by Worldcitizen 11 years ago.
The is the right patch that will work on svn navit

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by Worldcitizen

  • Priority changed from major to blocker
  • Summary changed from A few errors in version svn2304 to A few errors in version svn2304. I've created the fix as a patch

I've created the fix. There was a type and 3 missing items in header files.

comment:2 Changed 11 years ago by Worldcitizen

  • Summary changed from A few errors in version svn2304. I've created the fix as a patch to A few errors in version svn2304. I've created the fix as a patch for the current version svn2315

comment:3 Changed 11 years ago by Worldcitizen

This where the build errors:

map.c:534: warning: assignment makes pointer from integer without a cast street.c:1050: warning: assignment makes pointer from integer without a cast street.c:1158: warning: assignment makes pointer from integer without a cast street.c:1159: warning: assignment makes pointer from integer without a cast street.c:1287: warning: assignment makes pointer from integer without a cast

These error's weren't related to only x86_64

Changed 11 years ago by Worldcitizen

empty don't use

Changed 11 years ago by Worldcitizen

Changed 11 years ago by Worldcitizen

Patch name as i use also use in my navit-snapshot build. Is fully tested on version svn2315

Changed 11 years ago by Worldcitizen

The is the right patch that will work on svn navit

comment:4 Changed 11 years ago by Worldcitizen

Please use patch navit-fix.patch this one will work on the standard svn version

comment:5 Changed 11 years ago by Horwitz

  • Resolution set to fixed
  • Status changed from new to closed

The patch was applied to revision 2325

Note: See TracTickets for help on using tickets.