Opened 10 years ago

Last modified 8 months ago

#454 new enhancement/feature request

"set as position" should do "view on map", too

Reported by: arne.anka Owned by: cp15
Priority: trivial Milestone: version 0.6.0
Component: gui/internal Version: git master
Severity: Keywords:
Cc: thomas.arendsen.hein@…, sebastian.leske@…

Description

gui: internal. searching a town and selecting "set as position" does not move the position into view. since the town is not stored anwhere, "view on map" requires to search the town again. not only is that unnecessary tedious, but imo even unintuitive -- setting a sposition means to show that position as well.

Change History (8)

comment:1 Changed 10 years ago by arne.anka

  • Component changed from core to gui/internal
  • Owner changed from KaZeR to cp15

--- navit-0.1.0+svn.orig/navit/gui/internal/gui_internal.c 2009-08-18 22:22:47.000000000 +0200 +++ navit-0.1.0+svn/navit/gui/internal/gui_internal.c 2009-09-06 15:45:03.000000000 +0200 @@ -370,6 +370,7 @@

static int gui_internal_is_active_vehicle(struct gui_priv *this, struct vehicle *vehicle);

+static void gui_internal_cmd_view_on_map(struct gui_priv *this, struct widget *wm, void *data);

/*

  • * Display image scaled to specific size
  • * searches for scaleable and pre-scaled image

@@ -1682,6 +1683,7 @@

{

struct widget *w=wm->data; navit_set_position(this->nav, &w->c);

+ gui_internal_cmd_view_on_map(this, wm, data);

gui_internal_prune_menu(this, NULL);

}

comment:2 Changed 9 years ago by woglinde

  • Milestone set to To be discussed - Give your opinion!
  • Type changed from defect/bug to enhancement/feature request

Hi,

I want to discuss it. Should it be the default behavior, even when the enabled vehicle has a gps position or only when the vehicle has no gps-position or demo vehicle is used?

Bye Henning

comment:3 Changed 8 years ago by thomas arendsen hein

What is the semantic of using "set position" when GPS is available?

For the other cases (GPS position not (yet) available or demo vehicle) the position should be viewed immediately.

comment:4 Changed 8 years ago by thomas arendsen hein

  • Cc thomas.arendsen.hein@… added

comment:5 Changed 8 years ago by sleske

  • Cc sebastian.leske@… added

I'm not sure what happens if you use "set position" when GPS is avaible (don't have a GPS available). I believe it will work, but the next time GPS reports a position, the position will change back to the GPS position.

"set position" may still be useful when GPS is active - if you do not have a fix (yet), but know where you are, you can set the position manually and get a route immediately. As soon as GPS has a fix, it will take over.

As to moving the map to the position set by "set position": I agree that makes sense. I would not distinguish whether GPS is active or not. If it makes sense to use "set position", the map should change as well.

Maybe it would make sense to disable "set position" altogether if there is a GPS fix, but that's another problem...

comment:6 Changed 6 years ago by usul

  • Milestone changed from To be discussed - Give your opinion! to version 0.5.1

comment:7 Changed 2 years ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Milestone changed from version 0.5.1 to version 0.5.2

This ticket was pushed back in order to bring 0.5.1 out soon.

comment:8 Changed 8 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Milestone changed from version 0.5.2 to version 0.6.0

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.