Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#480 closed enhancement/feature request (fixed)

[patch] remove obsolete structs in navit_vehicle and initialization thereof.

Reported by: sera Owned by: KaZeR
Priority: major Milestone:
Component: core Version: git master
Severity: Keywords:
Cc:

Description

Hi,

please remove cursor, color and color2 from navit_vehicle, see patch for details.

Motivation: According to the navit_shipped.xml and the wiki they have a meaning. So I spent some time to figure out what they are supposed to do, nothing, and finally ended up asking stupid things on irc. To let not other tap in the same trap please remove them from the source and update the wiki. I'm willing to do the latter if you grant me access.

Regards sera

Attachments (1)

navit_remove_obsolete.patch (2.3 KB) - added by sera 11 years ago.
Removes obsolet structs and initialization thereof.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by sera

Removes obsolet structs and initialization thereof.

comment:1 Changed 11 years ago by horwitz

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in revision 2616. Please update the wiki.

comment:2 follow-up: Changed 11 years ago by sera

I've updated the wiki, hope it's fine this way.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 11 years ago by stuvel.eu

Replying to sera:

I've updated the wiki, hope it's fine this way.

The only thing I notice is the strange combination of "required" and "obsolete". It's strange to require something that's obsolete. Maybe it's better not to list them as "required"?

comment:4 in reply to: ↑ 3 Changed 11 years ago by sera

Replying to http://stuvel.eu/:

Replying to sera:

I've updated the wiki, hope it's fine this way.

The only thing I notice is the strange combination of "required" and "obsolete". It's strange to require something that's obsolete. Maybe it's better not to list them as "required"?

Thought so too but went with uniformity with optional(obsolete). Obsolete is sufficient in both cases so I'm gonna change that.

Note: See TracTickets for help on using tickets.