Opened 10 years ago

Closed 7 years ago

#481 closed enhancement/feature request (fixed)

Add map directory support

Reported by: zoff99 Owned by: cp15
Priority: minor Milestone: version 0.5.0
Component: core Version: git master
Severity: Keywords:
Cc:

Description

i have this set in the config file:

        <mapset enabled="yes">
            <map type="binfile" enabled="yes" data="/media/card/navit/maps/*.bin"/>
        </mapset>

but when there are 2 .bin files present only the first gets loaded. if i give only the directory (without *.bin) navit crashes and does not startup

Change History (7)

comment:1 Changed 10 years ago by sera

It's luck that this works for one map an not intentional. Map only takes a single map file as argument and a directory is not a file.

You should configure navit as follow:

<mapset enabled="yes">
  <map type="binfile" enabled="yes" data="/media/card/navit/maps/map1.bin"/>
  <map type="binfile" enabled="yes" data="/media/card/navit/maps/map2.bin"/>
</mapset>

comment:2 Changed 10 years ago by sera

  • Resolution set to invalid
  • Status changed from new to closed

No response in over 2 weeks and no actual bug here. Closing as invalid.

zoff99, feel free to reopen if you see the need.

sera

comment:3 Changed 10 years ago by zoff99

  • Priority changed from major to minor
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from navit only loads fir .bin file as map to navit only loads first .bin file as map

what kind of response would you like? there is definitly a bug.

in the documentation is states clearly! http://wiki.navit-project.org/index.php/OpenStreetMap#Tips

    *  To avoid changing navit.xml if you update your maps and the maps have different file names use the wildcard (*.bin) in your navit.xml file. For example: 

<map type="binfile" enabled="yes" data="/media/mmc2/maps/*.bin"/>

that i would like have working. it (would be) a great feature. e.g. if you travel you can just put france.bin and germany.bin on your SD-card and after the trip just delete one of those files, and all is well. WITHOUT having to have the navit.xml all the time.

comment:4 Changed 10 years ago by sera

  • Component changed from mapdrivers/OSM to core
  • Summary changed from navit only loads first .bin file as map to Add map directory support
  • Type changed from defect/bug to enhancement/feature request

This kind of response :).

This implies you remove the other one from the containing directory if it comes first in the alphabet and implies the OS supports globing. Really hackish, therefore in the tips section.

One could either implement the "multiple maps per map tag" or a "mapdir tag" or something slightly different - an add/remove map dialog in the gui.

A map directory with automatic map type detection and all maps enabled if the "mapdir" is enabled seems what you want. The map type detection is necessary as you could be using commercial maps for Germany and add an OSM map for France.

comment:5 Changed 10 years ago by zoff99

as a first step it would be enough to just try to load all '*.bin' files in a specific directory. and if the OS does not support globing or the files are not mapfiles just ignore them. that would not break any existing stuff, but would allow for the feature i described.

maybe have a new tag like this:

<map type="binfile_dir" enabled="yes" data="/media/mmc2/maps/"/>

and then all files in /media/mmc2/maps/ would be loaded as bin-type files, and if there is any kind of error just ingore and continue ...

comment:6 Changed 10 years ago by kazer

  • Milestone set to version 0.3.0

I agree that it could be convenient. Currently * would load xml files, each one of them describing one .bin.

comment:7 Changed 7 years ago by usul

  • Resolution set to fixed
  • Status changed from reopened to closed

This bug seems t be fixed during the years. I tried it with the mentioned config and the preshiped bin and on additional from my state. Works good-> close ticket.

Note: See TracTickets for help on using tickets.