Opened 9 years ago

Closed 9 years ago

#565 closed defect/bug (fixed)

Next/Prev buttons should be switched in roadbook - [patch included]

Reported by: tiiiim Owned by: number6
Priority: major Milestone:
Component: gui/internal Version: git master
Severity: Keywords: gui route
Cc:

Description

At the moment, the 'Next' and 'Prev' buttons are in the order Next/Prev?. It should really be Prev/Next? - i.e. forward/Next is right, and back/Prev is left, as with any browser, MP3 player, TV remote etc...

Attachments (5)

gui_internal.c.diff (232 bytes) - added by korrosa 9 years ago.
Switch Next/Prev? to Prev/Next? as per normal
gui_internal.c.2.diff (690 bytes) - added by korrosa 9 years ago.
Switch Next/Prev? to Prev/Next? as per normal (better diff)
gui_internal.c.3.diff (690 bytes) - added by korrosa 9 years ago.
next.prev.png (84.5 KB) - added by korrosa 9 years ago.
Before patch.
prev.next.png (86.6 KB) - added by korrosa 9 years ago.
After patch.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by korrosa

Switch Next/Prev? to Prev/Next? as per normal

Changed 9 years ago by korrosa

Switch Next/Prev? to Prev/Next? as per normal (better diff)

Changed 9 years ago by korrosa

comment:1 Changed 9 years ago by korrosa

  • Summary changed from Next/Prev buttons should be switched in roadbook to Next/Prev buttons should be switched in roadbook - [patch included]

Wow, how many times can I get that wrong!! Please ignore the first two files (I can't see an option to delete them) - it's the third one which is correct (*.3.diff).

comment:2 follow-up: Changed 9 years ago by number6

  • Cc nick@… added
  • Owner changed from cp15 to number6
  • Status changed from new to assigned

Don't worry about the files.

Can you please attach a screen shot of the current problem, and your patch in action, please. It'll make things far easier on me.

Changed 9 years ago by korrosa

Before patch.

Changed 9 years ago by korrosa

After patch.

comment:3 in reply to: ↑ 2 Changed 9 years ago by korrosa

Replying to http://wiki.navit-project.org/index.php/user:number6:

Don't worry about the files.

Can you please attach a screen shot of the current problem, and your patch in action, please. It'll make things far easier on me.

As requested - the first shows the roadbook (or Route Description) as currently in SVN, with the next and previous buttons in their (incorrect) positions. The second screenshot shows the result after the patch is applied, an just switches the Prev/Next? buttons so that they follow more normal conventions.

comment:4 Changed 9 years ago by number6

  • Cc nick@… removed
  • Keywords gui route added
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in Revision 3558

Possibly the quickest patch in Navit history!

Note: See TracTickets for help on using tickets.