Opened 9 years ago

Closed 9 years ago

#596 closed defect/bug (fixed)

not able to scroll bookmarks

Reported by: bschu Owned by: number6
Priority: minor Milestone: version 1.0
Component: gui/internal Version: git master
Severity: Keywords: bookmark.txt osd gui bookmarks
Cc: bernd@…, nick@…

Description

I have installed on n900: navit 0.2.0+dfsg.1-1maemo1~3347 navit-data 0.2.0~svn3048maemo navit-graphics-gtk-drawing-area0.2.0+dfsg.1-1maemo1~3347 navit-gui-internal 0.2.0+dfsg.1-1maemo1~3347

(navit-data has a different version, because this version has all xpm/*.png with sizes greater zero included - this seems to happen seldom)

Now that I have more bookmarks, I can not select them from gui, because I can not scroll down. (So I only can use the first bookmarks)

How can I scrll down ?

I also tried to use subdirectories within bookmarks, but this did not work. I also did not find a syntax description of bookmark.txt

Attachments (1)

gui_internal.c.diff (1.6 KB) - added by number6 9 years ago.
gui_internal.c.diff.correct_folder

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by akashihi

What gui type you are using?

comment:2 Changed 9 years ago by tegzed

Tryagain`s patch at http://navit.pastebin.com/NpfCmE0s solves the bookmark problem for me perfectly. It creates a nice pager for the bookmarks. The function with the same name as in the patch should be replaced in gui_internal.c in the current svn version. I suggest it to be committed.

Thanks Tryagain!

comment:3 Changed 9 years ago by korrosa

Another great patch from tryagain. I would modify it slightly: instead of having the "x.." at the top to go back a level, it should be up after "Bookmark". So, if I went into a folder called "Family", the top line would go "Bookmarks > Family", just as it does for the POIs. To go back a level, I click on "Bookmarks".

Two advantages: 1) Save a line for hand-held devices. 2) "x.." is not the norm in Navit.

(Also, please attach a proper patch to this ticket, and try to make it from the main navit folder, not within the internal folder. :) )

Changed 9 years ago by number6

gui_internal.c.diff.correct_folder

comment:4 Changed 9 years ago by number6

  • Cc nick@… added
  • Component changed from core to gui/internal
  • Keywords osd gui bookmarks added
  • Owner changed from KaZeR to number6

Patch updated to use folder structure.

The "X.." problem is annoying. On devices with small screens, it only shows a single bookmark per page!

As an aside, is it possible to have "Prev" vanish when on the first page, and "Next" vanish when you're on the last page?

comment:5 Changed 9 years ago by number6

  • Resolution set to fixed
  • Status changed from new to closed

Added in Revision 3803

Note: See TracTickets for help on using tickets.