Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#628 closed defect/bug (fixed)

Please follow API changes in most recent gpsd

Reported by: tegzed Owned by: KaZeR
Priority: minor Milestone:
Component: core Version: git master
Severity: Keywords:
Cc:

Description

Hello,

I have noticed that Navit with the latest git version of Gpsd failes to compile (GPSD_API_MAJOR_VERSION 5 ). The gps_open() function's signature is changed in the most recent gpsd.Now it returns gps_data_t as a pointer argument rather than by return value. I have created a little patch (see attached diff file) to solve this problem, however I am not familiar with autoconf and couldn't write a check for gpsd API version to conditionally compile gps_open. Can anybody add this conditional check to the configure process?

This change also fixes a possible segfault when debugging is enabled, priv->source is freed before the debugging line:

dbg(0,"gps_open failed for '%s'. Retrying in %d seconds. Have you started gpsd?\n", priv->source, priv->retry_interval);

uses it.

Thanks, David Tegze

Attachments (1)

vehicle_gpsd.c.diff (1.7 KB) - added by tegzed 9 years ago.
patch for GPSD API version 5

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by tegzed

Another API change: gpsd's gps_poll() function is changed to gps_read() in most revent gpsd api version 5. the patch file (vehicle_gpsd.c.diff) is updated.

Changed 9 years ago by tegzed

patch for GPSD API version 5

comment:2 Changed 9 years ago by tegzed

I updated the patch to support conditional compilation for gpsd API version 5 and older gpsds.

comment:3 Changed 9 years ago by woglinde

  • Resolution set to fixed
  • Status changed from new to closed

fixed with revison r3580, slightly modified to match the sourcecode layout

http://navit.svn.sourceforge.net/viewvc/navit?view=revision&revision=3580

comment:4 Changed 9 years ago by tegzed

Thanks,Woglinde!

Note: See TracTickets for help on using tickets.