Opened 8 years ago

Closed 8 years ago

#638 closed enhancement/feature request (fixed)

is_in:country should be parsed as is_in tag

Reported by: arnotixe Owned by: cp15
Priority: minor Milestone:
Component: mapdrivers/OSM Version: git master
Severity: Keywords: osm map maptool bin binfile
Cc: arno@…, nick@…

Description

navit's osm parser maptool does not tag cities as being in a country if the osm data is tagged only with the is_in:country tag.

It needs the is_in tag to contain the country name.

I therefore suggest the following diff to maptool/osm.c [svn rev3536]:

1048a1049,1055
> 	if (! strcmp(k,"is_in:country")) {
> 		/*	sometimes there is no is_in tag, only is_in:country. 
> 		   I put this here so it can be overwritten by the next if clause if there IS an is_in tag.
> 		*/
> 		strcpy(is_in_buffer, v);
> 		level=5;
> 	}

This works just great for me, I now have tons of cities to choose from when I press cities :D

Attachments (1)

osm.c.diff (593 bytes) - added by korrosa 8 years ago.
Turned the example into a patch, and updated so it will apply to r3619.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by arnotixe

  • Resolution set to worksforme
  • Status changed from new to closed

comment:2 Changed 8 years ago by arnotixe

  • Resolution worksforme deleted
  • Status changed from closed to reopened

ok maybe I was a bit quick closing the ticket there. Maybe someone with write access would put it into the svn code?

Changed 8 years ago by korrosa

Turned the example into a patch, and updated so it will apply to r3619.

comment:3 Changed 8 years ago by number6

  • Cc nick@… added
  • Keywords osm map maptool bin binfile added

Added in Revision 3620

comment:4 Changed 8 years ago by number6

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.