Opened 10 years ago

Closed 9 years ago

#657 closed defect/bug (fixed)

Crash when creating Distortion (with fix patch)

Reported by: jwernerny -2- Owned by: KaZeR
Priority: blocker Milestone:
Component: core Version: git master
Severity: Keywords:
Cc:

Description

The creation of a distortion file ("distortion.txt") will occasionally crash in popup.c. This is caused by not handling the possibility that the distortion file could not be created and ignoring the NULL pointer return from the "fopen(..)" call.

There is also a related issue in that "distortion.txt" is created in the current directory (more precisely, the directory navit was started from) not in specific directory. This leads to distortions being "lost" if navit is run from different directories.

The attached patch file contains fixes both for checking the file open and for always crating "distrotion.txt" in a fixed directory (I chose .navit).

Attachments (1)

popup_crash.diff (2.4 KB) - added by jwernerny -2- 10 years ago.
popup.c patch for crashing when distortion is created.

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by jwernerny -2-

popup.c patch for crashing when distortion is created.

comment:1 Changed 9 years ago by kazer

  • Resolution set to fixed
  • Status changed from new to closed

Patch applied in r3638, thank you!

Note: See TracTickets for help on using tickets.