Opened 7 years ago

Closed 4 months ago

#681 closed enhancement/feature request (fixed)

Please rename the "xpm" folder to "images"

Reported by: pini Owned by: http://wiki.navit-project.org/index.php/user:jkoan
Priority: major Milestone: version 0.5.1
Component: core Version: git master
Severity: normal Keywords: xpm, png, res
Cc: http://wiki.navit-project.org/index.php/user:pini, jkoankerich@…

Description

Hi,

Since it holds many images in other formats than xpm (svg, svgz, png) the name "xpm" isn't anymore appropriate for the images folder.

Especially at installation stage it would make more sense to have these files installed into - say - /usr/share/navit/images instead of /usr/share/navit/xpm.

Thanks.

Attachments (1)

icons-dir (1.9 KB) - added by pini 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by pini

comment:1 Changed 7 years ago by pini

Hi,

The attached patch renames the 'xpm' dir to 'icons' and has a fix in gui_qml.cpp to get this dir path from the function graphic_icon_path().

Thanks.

comment:2 Changed 7 years ago by pini

  • Cc http://wiki.navit-project.org/index.php/user:pini added

comment:3 Changed 4 years ago by usul

  • Keywords xpm png res added
  • Milestone changed from version 0.2.1 to version 0.6.0

I absolutly support this request. But as it includes some more work (updating build scripts and check issues with distro packages), I recommend to focus this on the next big feature release

comment:4 Changed 2 years ago by kazer

  • Milestone changed from version 0.6.0 to version 0.5.1
  • Severity set to normal

0.5.0 has just been released, we can do this for the next release now.

comment:5 Changed 6 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Owner changed from KaZeR to http://wiki.navit-project.org/index.php/user:jkoan
  • Status changed from new to assigned

As the milestone for 0.5.1 said we are not fokus on compatibility to 0.5.0

comment:6 Changed 6 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Cc jkoankerich@… added
  • Priority changed from minor to major

comment:7 Changed 4 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Resolution set to fixed
  • Status changed from assigned to closed

Hello Pini As you can see in PR: https://github.com/navit-gps/navit/pull/307 we now have moved the xpm folder to icons which really makes more sense since we try to get rid of xpm icons and use svg in future.

Also because you are the debian maintainer of navit it would be nice if it would be possible that you look at https://github.com/navit-gps/navit/pull/309 and say if cmake/cpack component install would be suitable for you so we could work more together with you and publish updates more frequently in the future. I know that this is of topic, but I hope I could get you contacted this way.

Jkoan (new member of the Navit team)

Note: See TracTickets for help on using tickets.