Opened 7 years ago

Last modified 2 weeks ago

#735 new enhancement/feature request

Map Icon for bookmark

Reported by: number6 Owned by: KaZeR
Priority: minor Milestone: version 0.5.2
Component: core Version: git master
Severity: Keywords: map, icon, bookmarks
Cc: nick@…, http://wiki.navit-project.org/index.php/user:kyros, http://wiki.test.navit-project.org/index.php/user:usul

Description

Can we please have navit "mark" a location on the map with an icon, if it exists in bookmarks.txt.

Here's an example.

I have bookmarked your Mom's House under "Bookmarks"

I'm walking down the street, near your Mom's House. I can see her house on the map. I see that your Mom's house is close by. I stop by for coffee and cookies...

Attachments (3)

bookmark.svg (7.9 KB) - added by kyros 7 years ago.
proposal for a bookmark icon in the maps
color_icons_green_home.svg (26.5 KB) - added by usul 4 years ago.
bookmark_32.png (1.3 KB) - added by usul 4 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by kyros

  • Cc http://wiki.navit-project.org/index.php/user:kyros added

comment:2 Changed 7 years ago by kyros

Here an icon which canbe used for a navit-bookmark in the maps

Changed 7 years ago by kyros

proposal for a bookmark icon in the maps

comment:3 Changed 7 years ago by sanderd17

A little remark on the icon: wouldn't it be better to use an icon without shading? Shading can lead to bad results on little screens.

comment:4 Changed 7 years ago by korrosa

You can already do this manually by using the navit_texfile format to create your own list of visible POIs. http://wiki.navit-project.org/index.php/Navit_textfile_format

Of course, this is just a workaround: having actual places defined in bookmarks.txt appear as icons on the map would be a good option.

comment:5 follow-up: Changed 7 years ago by tegzed

Nice icon! Thanks! I already could set up Navit to display my bookmarks without writing code. I just converted the attached svg to png by the Makefile of the xpm folder; put itemgra entries for item type bookmark to my navit.xml's layouts and added my $HOME/.navit/bookmark.txt to the active mapset (bookmark.txt is in navit textfile format). After this the bookmark icons are displayed correctly on the map.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 7 years ago by korrosa

Replying to http://wiki.navit-project.org/index.php/user:tegzed:

Nice icon! Thanks! I already could set up Navit to display my bookmarks without writing code. I just converted the attached svg to png by the Makefile of the xpm folder; put itemgra entries for item type bookmark to my navit.xml's layouts and added my $HOME/.navit/bookmark.txt to the active mapset (bookmark.txt is in navit textfile format). After this the bookmark icons are displayed correctly on the map.

You clever bugger!

comment:7 in reply to: ↑ 6 Changed 7 years ago by tegzed

Replying to http://wiki.navit-project.org/index.php/user:korrosa:

Replying to http://wiki.navit-project.org/index.php/user:tegzed:

Nice icon! Thanks! I already could set up Navit to display my bookmarks without writing code. I just converted the attached svg to png by the Makefile of the xpm folder; put itemgra entries for item type bookmark to my navit.xml's layouts and added my $HOME/.navit/bookmark.txt to the active mapset (bookmark.txt is in navit textfile format). After this the bookmark icons are displayed correctly on the map.

You clever bugger!

Thanks for the appreciative words, Korrosa :)

comment:8 Changed 4 years ago by usul

  • Cc http://wiki.test.navit-project.org/index.php/user:usul added

So to summarize:

  • issue is rawly fixed
  • a layer for bookmark icons need to be added to preshipped navit.xml
  • final Icon needs to be discussed (I mostly suggest some kind of map markers). Maybe later on allowing to use specific icons (as supported by KML/GML and other geo vector formats)

We might also check, if we might do some tweaks to make the bookmark lookup fast enough (see #444), esp. if the user visits different countries etc. as the geometries are very sparse.

Changed 4 years ago by usul

Changed 4 years ago by usul

comment:9 Changed 4 years ago by usul

Ok here is what we need:

a map link

<map type="textfile" data="$NAVIT_SHAREDIR/data/bookmark.txt"/>

Attention: WinCE port adds the bookmart.txt at /data but the linux uses directly the path

a layer

<layer name="bookmarks">
                <itemgra item_types="bookmark">
                        <icon src="bookmark_32.png"/>
                        <circle color="#009640" radius="0" width="0" text_size="10"/>
                </itemgra>
        </layer>

And a icon: (copied from openclipart.org). I think a symbol that flyes above the basemap (and our traditional map POIs) would be easier to recognize at small screens bookmark_32.png (see/discuss at https://forum.navit-project.org/viewtopic.php?f=14&t=415).

Can anybody merge that with SVN?

comment:10 Changed 4 years ago by usul

  • Keywords changed from map icon bookmarks to map, icon, bookmarks
  • Milestone changed from version 0.5.0 to version 0.5.1
  • Priority changed from major to minor

comment:11 Changed 2 weeks ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Milestone changed from version 0.5.1 to version 0.5.2

This ticket was pushed back in order to bring 0.5.1 out soon.

Note: See TracTickets for help on using tickets.