Opened 8 years ago

Last modified 3 months ago

#857 new defect/bug

FInd/fix missing icons

Reported by: themroc.myopenid.com Owned by: KaZeR
Priority: minor Milestone: version 0.6.0
Component: core Version: git master
Severity: Keywords: icons xpm png svg
Cc:

Description

Here is a script to list icon-files that appear in navit.xml but don't exist in xpm/. Also, it finds icons where only the extension is wrong, like camping.xpm vs. camping.png. For these cases (36 as of r4490) a corrected navit.xml will be emited. Requires Linux (or cygwin), perl, sort, uniq. Run it from the navit source dir (where navit_shipped.xml and xpm/ are) like:

check_icons.sh > new-navit.xml

Attachments (2)

check_icons.sh (1.3 KB) - added by themroc.myopenid.com 8 years ago.
check_icons_v2.sh (2.4 KB) - added by themroc.myopenid.com 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by themroc.myopenid.com

comment:1 Changed 8 years ago by themroc.myopenid.com

New&better version: v2 can convert icon-files, so users don't have to fumble with their .xml, they can just copy new icons over. The default however is to be extra smart - here's some example output:

./xpm/bench.png is missing, but ./xpm/bench.xpm is there - generating bench.png.
./xpm/stadium.xpm is missing, but ./xpm/stadium.png is there - fixing config-file.

call it like

  • ./check_icons_v2.sh fix-icon # always convert icon-files
  • ./check_icons_v2.sh fix-cfg > new-navit.xml # always fix the .xml
  • ./check_icons_v2.sh fix-best > new-navit.xml # the "smart" mode
  • (./check_icons_v2.sh fix-best-dry 2>&1) | more # just see what would happen w/o -dry

requires imagemagick.

Last edited 8 years ago by themroc.myopenid.com (previous) (diff)

Changed 8 years ago by themroc.myopenid.com

comment:2 Changed 8 years ago by themroc.myopenid.com

Yo! Would be nice if i could delete useless stuff like this comment...

Last edited 8 years ago by themroc.myopenid.com (previous) (diff)

comment:3 Changed 6 years ago by usul

  • Milestone set to version 0.5.1
  • Priority changed from major to minor
  • Type changed from enhancement/feature request to defect/bug

Thanks for that. I created something similar to check against binfile and style definitions (but on a item not icon base). We will make sure that the release includes only valid references.

comment:4 Changed 20 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Milestone changed from version 0.5.1 to version 0.5.2

This ticket was pushed back in order to bring 0.5.1 out soon.

comment:5 Changed 3 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Milestone changed from version 0.5.2 to version 0.6.0

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.