Opened 9 years ago

Last modified 18 months ago

#913 reopened defect/bug

Vehicle using NMEA, update position upon GPGGA sentence — at Version 3

Reported by: gregoire verlut Owned by: KaZeR
Priority: major Milestone: version 0.6.0
Component: core Version: git master
Severity: normal Keywords: gps, performance, nmea
Cc: cp15

Description (last modified by usul)

The current coding of vehicle_xxx_parse() in vehicle_wince and vehicle_file only set the ret to 1 when a GPRMC sentence is found ( )

as consequence the respective io function calls

#!cpp callback_list_call_attr_0(priv->cbl, attr_position_coord_geo);

only when the GPS receiver sends a GPRMC sentence.

Some GPS don't send any GPRMC (mine for example Sony Nav-u 51 based on GPS SiRF III)

the GPRMC infos are also found when combining GPGGA, a GPZDA and a GPVTG

Looking at the callback call, it seems that only the position is called-back, so I propose to set the ret to 1 also when a valid GPGGA is received (as workaround).

I attached a change for the vehicle_wince file. added 3 lines on after line 495

The same should be performed on the vehicle_file and other vehicle based on NMEA

Change History (4)

Changed 9 years ago by gregoire verlut

missing ;

comment:1 Changed 9 years ago by woglinde

Hi,

thanks for your modified files. To make the work for us developer easy. Please attach only patches. You can easy do a patch, when you checked out the source code with svn and running svn diff

Bye Henning

comment:2 Changed 7 years ago by usul

Is that already fixed?

comment:3 Changed 7 years ago by usul

  • Cc cp15 added
  • Description modified (diff)
  • Keywords gps performance nmea added
  • Milestone set to version 0.5.1

Sounds like a good idea to improve the time to fix (or at least till Navit detects the GPS)

Scheduled for 0.5.1 minor as this seems to be related to performance

Note: See TracTickets for help on using tickets.