Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#943 closed enhancement/feature request (fixed)

New feature: List of former destinations for internal GUI

Reported by: sleske Owned by: cp15
Priority: minor Milestone:
Component: gui/internal Version: git master
Severity: Keywords:
Cc: sebastian.leske@…

Description

When I asked on IRC about a good feature to get started with Navit development, it was proposed to implement a list of former destinations for the internal GUI.

This patch implements a list of former destinations for the "internal GUI".

It adds a new menu entry "Actions / Former Destinations" (after "Bookmarks"). This entry works mostly like the bookmarks, but instead of showing bookmarks, it shows the list of former destinations (read from list in destination.txt, which Navit already mantains).

The patch includes:

  • Code for the new menu entry (mostly in gui_internal.c, plus some in navit.c)
  • Some translation for the new strings necessary (for German, French Spanish and Dutch)
  • The new menu entry in navit_shipped.xml
  • Improved error reporting in textfile.c
  • A few new comments to methods and variable definitions

I'd be grateful for feedback (and inclusion into Navit, once the patch is deemed acceptable).

This patch is licensed under both the GPL and the LGPL (any version).

Attachments (1)

destination-list-gui-internal.patch (9.4 KB) - added by sleske 7 years ago.
Patch implementing the list of former destinations

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by sleske

Patch implementing the list of former destinations

comment:1 Changed 7 years ago by korrosa

Works like a charm! Brilliant stuff!

comment:2 Changed 7 years ago by korrosa

  • Resolution set to fixed
  • Status changed from new to closed

Patch committed in r4801: http://navit.svn.sourceforge.net/navit/?rev=4801&view=rev

Brilliant work sleske! NEXT!

comment:3 Changed 7 years ago by benja1972

Nice work!

One comment. When point from former destination is selected it would be nice to have in menu "Add as bookmark"

comment:4 follow-up: Changed 7 years ago by martin bruns

I also like it and think is a good step forward but would like to point out two more additions

  • Deletion of a selected destination would be nice.
  • Scrolling using the usual prev and next arrows would be nice

Should that be proposed with separate feature requests?

M

comment:5 in reply to: ↑ 4 Changed 7 years ago by korrosa

Replying to martin bruns:

[snip]

Should that be proposed with separate feature requests?

M

Yes, please open new tickets for these feature requests!

comment:6 Changed 7 years ago by sleske

  • Cc sebastian.leske@… added
Note: See TracTickets for help on using tickets.