Opened 7 years ago

Last modified 11 months ago

#993 new defect/bug

List of POI types icons doesn't fit the screen

Reported by: me.yahoo.com/a/t8pxanggmzrce9fscf2wgwk_ozmtbyifgarr#f3b4e Owned by: KaZeR
Priority: major Milestone: version 0.5.2
Component: core Version: git master
Severity: Keywords: menu poi display
Cc:

Description

  • Navit version: navit-svn-4879
  • Device: Samsung Galaxy Tab P1000
  • OS: Android 2.2
  • latest map from planet extractor

Go to Menu -> Actions -> Map point -> POIs

When device is oriented vertically/portrait, width is smaller, so the list with POI icons doesn't fit the screen. Last two icons do not fit the screen. Last icon is search, but I can not click on it. See attached screenshot: poi-icons-vertical.png

I think the list POI icons should be horizontally scrollable.

This is no problem when device is oriented horizontally/landscape because the list with POI icons fit the screen. Any icon can be clicked on. See attached screenshot: poi-icons-horizontal.png

Ciprian Alexan.

Attachments (2)

poi-icons-vertical.png (123.4 KB) - added by me.yahoo.com/a/t8pxanggmzrce9fscf2wgwk_ozmtbyifgarr#f3b4e 7 years ago.
poi-icons-horizontal.png (82.2 KB) - added by me.yahoo.com/a/t8pxanggmzrce9fscf2wgwk_ozmtbyifgarr#f3b4e 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by me.yahoo.com/a/t8pxanggmzrce9fscf2wgwk_ozmtbyifgarr#f3b4e

Changed 7 years ago by me.yahoo.com/a/t8pxanggmzrce9fscf2wgwk_ozmtbyifgarr#f3b4e

comment:1 Changed 7 years ago by korrosa

I also had this problem on a Galaxy S2. A workaround: opening navit.xml and altering the icon_s values inside the <gui... > tag.

See http://wiki.navit-project.org/index.php/Internal_GUI#Icon_and_font_sizes.

My gui tag now looks like:

<gui type="internal" icon_xs="32" icon_s="32" icon_l="64" enabled="yes" font_size="300">

Of course, scrolling the POI icons would be ideal... :)

comment:2 Changed 6 years ago by mvglasow (2)

Similar issue on the Nexus S, which is HDPI, thus icon_s defaults to 48. Since the device screen has a resolution of ~200 dpi and the icons are 96 dpi, the icons are scaled to roughly 100 (physical) pixels in either dimension (about twice their size).

Since in portrait orientation the screen is 640 pixels wide, only the first seven icons are shown (the last being cut off already). This is especially painful because the Search icon is missing, being the last in the row and the first to be cut off, despite being the one I need most frequently.

Setting icon_s to 32 makes the icons just small enough to fit 10 in a row, but reduces their clickability.

What would help:

  • A scrollable toolbar
  • Some other kind of "overflow" to have the most common icons in view and the others available after clicking a "More" button or similar
  • Putting the Search icon first
  • A configurable list of POI buttons

comment:3 Changed 6 years ago by tryagain

For me, POI types are split into two (or more) rows when whole list does not fit on one row.

That behavior was implemented since r3621.

I have retested this on Android (HTC Wildfire S, month or so svn) and linux(current svn), it works fine for me.

I think the bug may be related to Android platform and overlay usage.

Can you verify if the bug reproduces for you with stock navit.xml and/or on any platform besides Android?

Last edited 6 years ago by tryagain (previous) (diff)

comment:4 Changed 6 years ago by mvglasow (2)

Verified with r5187 and navit-hdpi.xml extracted from apk, no modifications. The behavior is the same, one line of POIs which is chopped off at the end.

Additionally, the icons seem a little bit too large for the available space and cover the lowest ~5 pixels of the menu bar.

I'll see if I can reproduce this on other platforms.

comment:5 Changed 6 years ago by antiram

the nitems ignores the search item. in gui_internal_cmd_pois_selector replace

nitems=(sizeof(selectors)/sizeof(struct selector));

with

nitems=(sizeof(selectors)/sizeof(struct selector))+1;

and replace

for (i = 0 ; i < nitems ; i++) {

with

for (i = 0 ; i < nitems-1 ; i++) {

its also part of last patch in ticket:1040

comment:6 Changed 5 years ago by usul

  • Keywords display added
  • Milestone set to version 0.5.1

comment:7 Changed 11 months ago by http://wiki.navit-project.org/index.php/user:jkoan

  • Milestone changed from version 0.5.1 to version 0.5.2

This ticket was pushed back in order to bring 0.5.1 out soon.

Note: See TracTickets for help on using tickets.