Custom Query (1067 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (31 - 33 of 1067)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21
Ticket Resolution Summary Owner Reporter
#1319 fixed announcement of destination at intersections KaZeR rico (2)
Description hi,

announcement of destination at an intersections does only work for oneways because attr_street_destination_forward/backward is not set by maptool.

A little patch is attached to solve this. If there is only a destination tag without backward/forward (is sometimes used in osm when the direction is not ambiguous) attr_street_destination_forward and backward is set to the value of destination
#1316 fixed Use-after-free bug in binfile.c KaZeR lessandro
Description I've ran Navit through a dynamic analysis tool (Pareon Verify) and found several memory leaks, code using memory that has already been free'd, and code using memory that has not been initialized.

I've added the report from the tool for the use-after-free case as an attachment. Here's my analysis of it, which happens in binfile.c:2128-2140.

{{{#!c
1 -> map_rec = map_rect_new_binfile(map, NULL);
2 -> town = map_rect_get_item_byid_binfile(map_rec, map->last_searched_town_id_hi, map->last_searched_town_id_lo);
if (town)
msp->mr = binmap_search_street_by_place(map, town, &c, &msp->ms, &msp->boundaries);
3 -> map_rect_destroy_binfile(map_rec);
if (msp->boundaries)
dbg(lvl_debug, "using map town boundaries\n");
if (!msp->boundaries && town)
{
4 -> binmap_get_estimated_boundaries(town, &msp->boundaries);
if (msp->boundaries)
dbg(lvl_debug, "using estimated boundaries\n");
}
}}}

1. `map_rec` allocated
2. `town` is a pointer to a field inside `map_rec`
3. `map_rec` freed, therefore `town` now points to deallocated memory
4. `town` is used

A fix for this would be to move the deallocation (3) further down the switch case.
#1315 fixed navit_shipped.xml (reference improvement) KaZeR bobbib
Description Just a small improvement of the "navit_shipped.xml" header comments.

{{{
--- trunk/navit/navit/navit_shipped.xml
+++ trunk/navit/navit/navit_shipped.xml.new
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?><!--
For configuration options used in this file, please read
- http://wiki.navit-project.org/index.php/Configuring_Navit
- Do not edit /usr/share/navit/navit.xml : changes would be lost
- on upgrade. Rather copy it to ~/.navit/.
+ http://wiki.navit-project.org/index.php/Configuration
+ Do not edit /usr/share/navit/navit.xml or /etc/navit/navit.xml :
+ changes would be lost on upgrade. Rather copy it to ~/.navit/.
-->
<!DOCTYPE config
SYSTEM "navit.dtd">

}}}
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21
Note: See TracQuery for help on using queries.