Opened 10 years ago
Last modified 3 years ago
#1029 new defect/bug
odometer reset crash navit
Reported by: | heiko wegeler | Owned by: | KaZeR |
---|---|---|---|
Priority: | major | Milestone: | version 0.6.0 |
Component: | core | Version: | git master |
Severity: | Keywords: | odometer, osd, crash | |
Cc: |
Description
please add this to navit.xml
<osd enabled="yes" type="odometer" w="350" h="40" x="30" y="300" font_size="450" label="Time:${time}" name="persistent_odometer_1" disable_reset="1" autostart="1"/> <osd enabled="yes" type="text" label="reset" x="200" y="200" command="odometer_reset("persistent_odometer_1")"/>
start navit, click reset item -> crash.
with disable_reset="0" the reset with doubleclick on the time item works.
Attachments (2)
Change History (11)
comment:1 Changed 10 years ago by heiko wegeler
- Summary changed from osd reset crash navit to odometer reset crash navit
comment:2 Changed 10 years ago by tegzed
Hello Wegeler,
Hopefully I fixed this problem. Please check svn 5062 or a newer build and close ticket if it's OK on your side too.
Changed 10 years ago by heiko wegeler
comment:3 Changed 10 years ago by heiko wegeler
Hello KaZeR,
no crashes now, thanks.
But wiki says reset command is for use with disable_reset="1", which was not the case. Moved "if (!this->bDisableReset)" to osd_odometer_click.
and reset command sets odometer inactive. Should untouched. Changes in osd_cmd_odometer_reset to set time to 0.
comment:4 Changed 10 years ago by antiram
changeset:5224 is only part of a fix. After click reset button, the odometer items ends always in stop mode if autostart=1 is set.
odometer2.diff for r5224 respects autostart=1 (like first odometer.diff)
comment:5 Changed 10 years ago by antiram
changeset:5225 is more buggy. After click reset button, the odometer time item is not resetted. You need the lines 527-533 from odometer2.diff somewhere.
Btw, my odometer patch works since 4 month and don't need this unreadable flag in osd_odometer_reset.
comment:6 Changed 9 years ago by usul
- Keywords odometer osd crash added
- Milestone set to version 0.5.1
Summary: Check if the odometer OSD widget behaves as expected.
comment:7 Changed 9 years ago by heiko wegeler
no new test required because no change was made in the last 10 month, which addresses this.
I use currently 5532 with odometer changes for this and other bugs and new features for cycling, therefore i can't post an updated patch only for this again.
comment:8 Changed 5 years ago by http://wiki.navit-project.org/index.php/user:jkoan
- Milestone changed from version 0.5.1 to version 0.5.2
This ticket was pushed back in order to bring 0.5.1 out soon.
comment:9 Changed 3 years ago by http://wiki.navit-project.org/index.php/user:jkoan
- Milestone changed from version 0.5.2 to version 0.6.0
Ticket retargeted after milestone closed
crash at line 782 in osd_core.c