Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1244 closed defect/bug (fixed)

untranslated county_sep in gui internal

Reported by: jandegr Owned by: cp15
Priority: minor Milestone:
Component: gui/internal Version: git master
Severity: normal Keywords: translation


Hi, line 157 char *county_sep =", Co. "

Co. is short for county, but should go through the thranslation thing. Since county_sep can have another meaning in different countries, simply changing it into: char *county_sep =", " might be even a better solution !

Users will know themselves if the shown value is a province, a county, a region or whatever we map to a county_ (c in maptool/osm.c) shows it in the gui, (pic. credit to bafplus)

reagrds, Jan

Change History (4)

comment:1 Changed 8 years ago by sleske

Yes, always showing "Co. " as county separator is rather confusing. Translating it is probably not enough, because Navit's "county" represents different things in different countries, and sometimes even within one country.

Navit takes its "county" from boundaries with a certain OSM "admin_level" - usually level 6, but e.g. 3 in the Netherlands (that is set in the country table in maptool/osm.c). As you can see from Tag:boundary=administrative in the OSM wiki, many levels have more than one meaning even within a single country. For example, in Switzerland it can be a "Bezirk" or a "Amt", in Germany it can be "Landkreis" or "Kreisfreie Stadt", in Russia it can be a "municipal district" or an "okrug".

So for now I think the best solution is to omit the "county" designation, and just use a comma, as you proposed.

If we do that, we should consider not showing the "county" name if it is identical to the town name (which would look confusing). This can happen for big towns/cities, which are "their own county". This often occurs in Germany for a "kreisfreie Stadt"; I believe there's something similar in Russia.


comment:2 Changed 8 years ago by jandegr

excuse me for reacting only after you already committed it, but I agree 100% with your comment and the commit. (r5920)

thanks, Jan

Last edited 8 years ago by jandegr (previous) (diff)

comment:3 Changed 8 years ago by jandegr

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 8 years ago by sleske

No problem - it's never too late for a good comment :-).

Anyway, summary of changes:

I have changed the "county separator" to just a comma. So the street from your example screenshot will now be show as "Heksenakker", with subtitle "Breda, Noord-Brabant". Also, the "county" is not shown at all if it has the same name as the city. Otherwise, in large German cities (which are "their own county") streets would be displayed like "Köngisallee", "40213 Düsseldorf, Düsseldorf", which is not very helpful.

See r5920 and r5921.

Note: See TracTickets for help on using tickets.