Opened 8 years ago
Closed 8 years ago
#1271 closed enhancement/feature request (fixed)
next named street in route
Reported by: | jandegr | Owned by: | KaZeR |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | core | Version: | git master |
Severity: | normal | Keywords: | |
Cc: |
Description
investigating this post https://forum.navit-project.org/viewtopic.php?f=12&t=516&start=10 it turns out command.c can only handle the '@' char following '[' I made a rudimentary hack to allow [0]....[5] to be handled to make the forum post possible. It also makes the reported errors more human-friendly, what's the use in reporting error n° 10 if a user has no single clue to what the meaning of 10 might be.
the pacth makes the use of following examples possible in a command:
navigation.item[1].street_name "${navigation.item[1].street_name}"
regards, Jan
Attachments (1)
Change History (6)
comment:1 Changed 8 years ago by jandegr
comment:2 Changed 8 years ago by jandegr
Hi, solving it through command.c seems to be not trivial and those commands with periodical reevaluation also take quite a bit of CPU. With 5 of them active and a refresh of 1 second I can make the device unresponsive. Below another solution, functionally almost identical to the solution with a command.
<osd enabled="yes" name="next_street" type="text" align="4" label=">${navigation.item[1].street_name} ${navigation.item[1].street_name_systematic}>${navigation.item[2].street_name} ${navigation.item[2].street_name_systematic}>${navigation.item[3].street_name} ${navigation.item[3].street_name_systematic}" w="320" x="125" y="135"/>
The available names shift to the left and the brackets give an indication of the number of unnamed sections. Unfortunatly through navigation.item we can only have street_name_systematic if there is a street_name for the same section.
regards, Jan
Changed 8 years ago by jandegr
comment:3 Changed 8 years ago by jandegr
- Summary changed from command.c can not handle array style notations to next named street in route
comment:4 Changed 8 years ago by jandegr
Hi, After some more searching I found that streetnames are not available if you don't maneuvre to that street, for example Navit does not merge onto a highway, so it's name is not available throug navigation.item[x]. It has nothing to do with what I suspected before regarding : we can only have street_name_systematic if there is a street_name for the same section this was pure coincidence.
regards, Jan
comment:5 Changed 8 years ago by jandegr
- Resolution set to fixed
- Status changed from new to closed
this ticket made me introduce the new merge command in H5, so closing it now because committed entirely in r6090
unfortunatly string comparison in the conditionals don't work either........