Opened 7 years ago

Closed 6 years ago

#1339 closed enhancement/feature request (fixed)

Town search: Hide OSD keyboard keys instead of highlighting

Reported by: sleske Owned by: sleske
Priority: major Milestone:
Component: gui/internal Version: git master
Severity: normal Keywords:


In the address search dialog of the internal GUI, the OSD keyboard currently (tries to) provide hints by highlighting "possible" keys (keys that will provide results if pressed next).

Unfortunately, this feature does not work well when the OSD keyboard is operated using cursor keys or a rotary encoder (implemented recently): The hint highlighting and the keyboard focus highlighting collide, and since un-highlighted keys remain accessible, navigating the keyboard requires many keypresses.

To improve this, greg42 provided a patch to completely hide (and disable) not possible keys, instead of highlighting possible keys. The patch was originally part of pull request #5 on GitHub?; it is now available in branch pr-5-hide-keys.

One problem remains to be solved before merging this patch:

The search is case-insensitive and accepts unaccented for accented letters (i.e. it finds results with é for input e, or with ü for input u [but not vice versa]). The possible keys highlighting does not follow this behaviour. For example, in the town search in Germany, the input "Mul" or "mül" will find "Mülheim", but the "h" key will not be highlighted. Similarly, if the next possible key is an accented letter, the corresponding un-accented key is not highlighted. Example: Search input "Schl" will find "Schlüterstraße", but "u" will not be highlighted (this bug occurs less often, because often there will be another result with the un-accented letter - "u" in this case - so highlighting still occurs).

Currently, this only means that key highlighting is incomplete. However, with the patch applied these keys will be hidden instead, even though they would produce a result - which in turn can mean that some results cannot be obtained via the OSD keyboard, forcing the user to go through the list.

Change History (2)

comment:1 Changed 7 years ago by sleske

  • Owner changed from cp15 to sleske

comment:2 Changed 6 years ago by sleske

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in branch pr-5-hide-keys, and merged in PR 210. Thanks to all involved!

Note: See TracTickets for help on using tickets.