Opened 13 years ago
Closed 12 years ago
#484 closed defect/bug (fixed)
random crash when clicking on map using heavy osd
Reported by: | mibraun | Owned by: | KaZeR |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | core | Version: | git master |
Severity: | Keywords: | ||
Cc: |
Description
Hi,
I found the current SVN HEAD to crash randomly when clicking on the map with left or right mouse button, preferrably when both gps is disabled ( the demo:/// device is used) and a heavy osd skin is used.
Applying
Index: navit/navit/osd.c =================================================================== --- navit/navit/osd.c (Revision 2634) +++ navit/navit/osd.c (Arbeitskopie) @@ -72,7 +72,7 @@
if (navit_ignore_button(nav))
return;
this->pressed = pressed;
- if (pressed) {
+ if (pressed && this->command) {
struct attr navit; navit.type=attr_navit; navit.u.navit=nav;
avoids the crash, although some clicks get ignored. The debug output contains "calling command: (null)" and the crash occurs in command_evaluate in osd_std_click in navit_handle_button.
I included the attached skin.xml in navit.xml
Attachments (1)
Change History (3)
Changed 13 years ago by mibraun
comment:1 Changed 12 years ago by korrosa
comment:2 Changed 12 years ago by korrosa
- Resolution set to fixed
- Status changed from new to closed
Still an issue?