Opened 9 years ago
Last modified 2 years ago
#978 new defect/bug
Use GetWindowLongPtr and GWLP_HINSTANCE.
| Reported by: | kgbricola | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | version 0.6.0 |
| Component: | port/windows | Version: | git master |
| Severity: | Keywords: | windows, win32, api, code quality | |
| Cc: | cp15 |
Description
The attached patch removes the deprecated usage of GWL_HINSTANCE and GetWindowLong? for win32.
Attachments (1)
Change History (8)
Changed 9 years ago by kgbricola
comment:1 Changed 9 years ago by sleske
comment:2 Changed 9 years ago by openid-provider.appspot.com/kgbricola@…
Well, the question is, what needs to be done to get the patch in? Does it need some tests if it breaks something? Is there needed someone to review it? Has anyone an opinion about it, what needs to be improved in the patch before it could be accepted? Is the patch in the wrong format?
comment:3 Changed 9 years ago by tegzed
Hi kgbricola, I'm not using the windows port, but I think some feedback with different win32 toolchains (mingw32, different msvc versions) would be useful.
comment:4 Changed 8 years ago by usul
- Cc cp15 added
- Keywords windows win32 api code quality added
- Milestone set to version 0.5.1
Obviously this patch hadn't been applied and is waiting for feedback. I'm not sure if we will still support the win32 GUI because currently we have very limited resources :/
comment:5 Changed 8 years ago by sleske
Well, I see no problem with supporting the Win32 GUI - if there's someone willing to work on it. Maybe the OP is interested?
I can apply the patch; I just need someone who can build on Windows to test it for me.
comment:6 Changed 3 years ago by http://wiki.navit-project.org/index.php/user:jkoan
- Milestone changed from version 0.5.1 to version 0.5.2
This ticket was pushed back in order to bring 0.5.1 out soon.
comment:7 Changed 2 years ago by http://wiki.navit-project.org/index.php/user:jkoan
- Milestone changed from version 0.5.2 to version 0.6.0
Ticket retargeted after milestone closed
Hey, the win32 GUI is alive :-). There have been no substantial patches since December 2009...